I agree, but for example; Ship inherits Item, and contains a Design which ALSO inherits from Item. That's pretty redundant.
I'd rather have Ship inherit a Design directly so there's a clear line of inheritance.
And as stated somewhere in the code in an old comment, Item should inherit from design, and not the other way around. It makes no sense for a design to have mass and position; an Item is a much more "concrete" thing anyway, so it should logicaly be lower down in the implementation chain than a design.
Although I also concede that this kind of logic not always makes sense in software, and I don't know what implications reversing the inheritance might have on the codebase other than the Key properties we worked so hard to implement would need to be realocated to track designs by Id.
Design -> ShipDesign -> Item -> Ship
Would be an ideal arrangement, instead of the current:
Item -> Ship
|->Item -> Design -> Shipdesign
Even
Item -> Design -> Shipdesign -> Ship
Would be cleaner, and it could be a simpler change to implement.
Members
Search
Help
Register
Login
Home
