Home World Forum
Stars! AutoHost web forums

Jump to Stars! AutoHost


 
 
Home » Stars! Clones, Extensions, Modding » Stars! Nova - Development » FleetIntel question
Re: FleetIntel question Wed, 13 July 2011 21:35 Go to previous messageGo to previous message
Aeglos is currently offline Aeglos

 
Chief Warrant Officer 1
Stars! Nova developer
Stars! Nova developer

Messages: 142
Registered: May 2011
Location: Chile
Having done progress on this, I think it's a dead end to be honest. I also think we might be overcomplicating things due to our inclination to model this relationship in some oop way after my initial changes ( Embarassed )

There is a problem with the 'has-a' approach: The Star Report fields need all to be set with the proper real data inside the Star's report property for it (Star) to work properly, so we would need a special method to select the right amount of data according to the knowledge level for each object anyway, as we simply can't retrieve the full report; we would still be passing extra data (like colonists or concentration on unexplored stars).

Now that we've agreed to have them in separate owned/report collections again, we don't really need them to conform to a common interface or be polymorphic; we clearly aren't going to mix them up in the client. We won't be looking at the OwnedStars to draw the StarMap for example, and we won't be trying to access production queues on neutral stars.

I strongly think that we should treat them as what they are; diferent things, and be done with it. Star and Fleet (right as they are now) should have a GenerateReport(IntelLevel) method that creates and returns a new, distinct and separate P.O.D. StarIntel/FleetIntel object with the amount of fields set according to IntelLevel, with some sensible defaults.

I realize that this is probably going full circle to something really close to Ken's (or was it someone else's?) original design... but it's what's making the most sense after trying the other approaches in-code. Mea Culpa for braking this in the first place instead of improving the design already in place.


[Updated on: Wed, 13 July 2011 21:36]

Report message to a moderator

 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Bugs/Other Trackers
Next Topic: Anyone still around?
Goto Forum:
  


Current Time: Sat May 04 11:19:13 EDT 2024