Home World Forum: FreeStars » some questions about coding

Home » Stars! Clones, Extensions, Modding » FreeStars » some questions about coding

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

some questions about coding

Wed, 09 March 2005 03:33

ConstB

Crewman 1st Class

Messages: 27
Registered: March 2005
Location: Tomsk, Russia

Just checked out this fun piece of code and found it to be a bit strange.

1.
Let's see, every time you have to report some error and finish execution you are writing something like:

if (somethingWentWrong) {
    Message * mess = TheGame->AddMessage("Error: Invalid FreeStarsVersion");
    mess->AddItem(File);
    mess->AddItem(GetString(node->FirstChild("FreeSta rsVersion")));
    return false;
}

And if you have nested function calls this makes you code one huge error processing. Why don't you use c++ exceptions? they work quite fine even in your aged msvc6.

2.
Looks like you're writing freestars only for english speaking players. As I haven't seen a word about use of unicode or at least utf-8.

3.
You're creating Game object as a single "Game * TheGame" declaration an then export it for other modules. Quite simple but why not make it singleton?

4.
By the way, images in "FreeStars Classes.RTF" are not shown in my ms word 2000. :-(

Report message to a moderator

[Message index]

		some questions about coding By: ConstB on Wed, 09 March 2005 03:33
		Re: some questions about coding By: LEit on Wed, 09 March 2005 10:51
		Re: some questions about coding By: PricklyPea on Wed, 09 March 2005 10:57
		Re: some questions about coding By: LEit on Wed, 09 March 2005 11:01
		Re: some questions about coding By: ConstB on Wed, 09 March 2005 12:08
		Re: some questions about coding By: LEit on Wed, 09 March 2005 13:01
		Re: some questions about coding By: ConstB on Wed, 09 March 2005 13:39
		Re: some questions about coding By: PricklyPea on Wed, 09 March 2005 14:32
		Re: some questions about coding By: LEit on Wed, 09 March 2005 21:42
		Re: some questions about coding By: Downsider on Thu, 10 March 2005 19:46
		Re: some questions about coding By: ConstB on Fri, 11 March 2005 05:04
		Re: some questions about coding By: mazda on Fri, 11 March 2005 05:48
		Re: some questions about coding By: Madman on Mon, 14 March 2005 02:52
		Re: some questions about coding By: ConstB on Wed, 09 March 2005 14:35
		Re: some questions about coding By: ConstB on Wed, 09 March 2005 14:51
		Re: some questions about coding By: ConstB on Wed, 09 March 2005 15:05
		Re: some questions about coding By: ConstB on Thu, 10 March 2005 12:40
		Re: some questions about coding By: PricklyPea on Thu, 10 March 2005 13:54
		Re: some questions about coding By: ConstB on Fri, 11 March 2005 05:18
		Re: some questions about coding By: mazda on Fri, 11 March 2005 05:58
		Re: some questions about coding By: m.a@stars on Fri, 11 March 2005 07:49
		Re: some questions about coding By: ConstB on Fri, 11 March 2005 08:24
		Re: some questions about coding By: m.a@stars on Fri, 11 March 2005 08:40
		Re: some questions about coding By: ConstB on Fri, 11 March 2005 12:02
		Re: some questions about coding By: m.a@stars on Sat, 12 March 2005 07:45
		Re: some questions about coding By: Marduk on Thu, 17 March 2005 18:30
		Re: some questions about coding By: PricklyPea on Thu, 17 March 2005 18:56
		Re: some questions about coding By: m.a@stars on Fri, 18 March 2005 19:48
		Re: some questions about coding By: PricklyPea on Fri, 18 March 2005 22:25
		Re: some questions about coding By: m.a@stars on Sun, 20 March 2005 06:25
		Re: some questions about coding By: m.a@stars on Fri, 18 March 2005 07:24
		Re: some questions about coding By: Marduk on Sat, 19 March 2005 20:50
		Re: some questions about coding By: m.a@stars on Sun, 20 March 2005 06:20
		Re: some questions about coding By: m.a@stars on Sun, 20 March 2005 18:56
		Re: some questions about coding By: ConstB on Fri, 11 March 2005 07:52
		Re: some questions about coding By: PricklyPea on Fri, 11 March 2005 09:39
		Re: some questions about coding By: ConstB on Sat, 12 March 2005 08:19
		Re: some questions about coding By: m.a@stars on Sat, 12 March 2005 09:19
		Re: some questions about coding By: ConstB on Thu, 17 March 2005 12:48
		Re: some questions about coding By: LEit on Sun, 19 February 2006 22:12
		Re: some questions about coding By: m.a@stars on Mon, 20 February 2006 04:48
		Re: some questions about coding By: Kotk on Mon, 20 February 2006 06:03
		Re: some questions about coding By: m.a@stars on Mon, 20 February 2006 08:55
		Re: some questions about coding By: Kotk on Mon, 20 February 2006 10:49
		Re: some questions about coding By: m.a@stars on Mon, 20 February 2006 11:21
		Re: some questions about coding By: Kotk on Mon, 20 February 2006 15:58
		Re: some questions about coding By: m.a@stars on Tue, 21 February 2006 05:02
		Re: some questions about coding By: LEit on Tue, 21 February 2006 13:31
		Re: some questions about coding By: Kotk on Tue, 21 February 2006 14:04
		Re: some questions about coding By: m.a@stars on Tue, 21 February 2006 21:51
		Re: some questions about coding By: PricklyPea on Mon, 20 February 2006 12:08
		Re: some questions about coding By: Kotk on Mon, 20 February 2006 16:31
		Re: some questions about coding By: ninja_squirrel on Fri, 20 October 2006 21:34
		Re: some questions about coding By: Kotk on Sat, 21 October 2006 04:06
		Re: some questions about coding By: m.a@stars on Sat, 21 October 2006 04:24
		Re: some questions about coding By: ninja_squirrel on Sat, 21 October 2006 16:24
		Re: some questions about coding By: Kotk on Sat, 21 October 2006 17:00
		Re: some questions about coding By: ninja_squirrel on Sat, 21 October 2006 18:26
		Re: some questions about coding By: ninja_squirrel on Sun, 22 October 2006 21:05
		Re: some questions about coding By: m.a@stars on Mon, 23 October 2006 04:16

Previous Topic:	Summary of Math?
Next Topic:	Need web hosting for Race Wizard

Goto Forum:

-=] Back to Top [=-

Current Time: Thu May 09 12:42:06 EDT 2024