Musmuris wrote on Sun, 03 July 2011 23:18

Daniel wrote on Fri, 01 July 2011 07:56 I have modified Item.Owner to bit shift values passed in or out so they are in the range 0 to 0x7F instead of being Item.Id & 0x7F000000. This allows code of the form item.Owner = 1 instead of item.Owner = (1 << 24); I also added some unit tests for item.Owner and item.PureId properties. This fixes a couple of the integration tests for the battle engine, but there are more to go. It might fix the tests.... but it breaks the making of a new game! So i've just reverted that change locally so I can carry on until we decide what to do

        /// <summary>
        /// Backing store for the game wide unique key. 
        /// First bit is for sign. Negative values are reserved for special flags.
        /// Bits 2-24 are reserved.
        /// Bits 25-32 are for the empire.Id aka Owner.
        /// Bits 33-64 are the Item.Id, which is a number generated by the client and unique for objects owned by that empire.
        /// Bit map is:
        /// S-----------------------OOOOOOOOIIIIIIIIIIIIIIIIIIIIIIIIIIII IIII
        /// IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIII
        /// ^                  ^                ^            ^
        /// +-- sign bit       +-- reserved     +-- owner    +-- client generated Id
        /// </summary>
        private long key = Global.NoOwner; // Default to no-id and no owner.